Some people like em, some hate em!
I've had mine since the bike was new four years ago and they've been fitted pretty much all of that time. They've survived a couple of drops and the locks are still the originals and work well. The locks are a problem if you're not careful, treat them well and they will return the favour. I lost one hinge pin last year, but that was easily sorted. My only real criticism is they're a bit small (for me) at 29L, but then I'm probably guilty of carrying too many creature comforts in my old age!
Would I buy them again with the benefit of hindsight? Probably not, I got a good deal on them at the time and in 2008 there wasn't a lot else to choose from, and what there was was twice as much money. Starting again in 2012 I'd plump for Ardcases I think...
http://ardcases.co.uk/products-and-prices/